Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds streamable feature to the library #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ImanMh
Copy link

@ImanMh ImanMh commented Jul 9, 2019

Hi there. I've been working on this feature to make it possible to stream SSR react projects made with isomorphic-style-loader. Even though this is not backward compatible I sent you the initial modifications so that we can discuss on what I'm doing here. With this implementation the only change that you need to make to the code is this:

<StyleContext.Provider value={{ insertCss, css, isServer: true }}>
  <ClientRoot manifest={manifest} />
</StyleContext.Provider>

Users of this library must pass the CSS set and a flag that shows if this code is running on server or not (which can be detected by default if not provided but passing CSS set is mandatory). Before I go ahead and add tests for this feature let me know your thoughts. If you merge this we can have corresponding improvements on react-starter-kit as well.

@ImanMh
Copy link
Author

ImanMh commented Jul 9, 2019

this will fix #164

@ImanMh
Copy link
Author

ImanMh commented Jul 24, 2019

@frenzzy could you please check this out?

@frenzzy
Copy link
Member

frenzzy commented Jul 24, 2019

@ImanMh sorry, I am not interested in maintenance isomorphic-style-loader anymore since I switched to using Emotion (this feature is already there)

@koistya maybe deprecate this project in favor of something else or add a bold message to the readme about searching new maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants