Skip to content

Commit

Permalink
Merge pull request #43 from ag5/fix/akv-backend
Browse files Browse the repository at this point in the history
Fixed akv, from PR #34
  • Loading branch information
amohabir authored Nov 1, 2022
2 parents 9481624 + 8d61602 commit 007e3d9
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 14 deletions.
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changes

### v1.12.2

- Fixed AKV client

### v1.12.1

- Fixed AKV client
Expand Down
31 changes: 17 additions & 14 deletions backend/akv.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package backend
import (
"context"
"github.com/Azure/azure-sdk-for-go/sdk/keyvault/azsecrets"
"time"
)

type AKV struct {
Expand All @@ -14,15 +15,15 @@ func NewAKV(client *azsecrets.Client) *AKV {
}

func (b *AKV) Get(ctx context.Context, _ *Profile, key string) ([]byte, error) {
resp, err := b.client.GetSecret(ctx, key, "", nil)
resp, err := b.client.GetSecret(ctx, key, nil)
if err != nil {
return nil, err
}
return []byte(*resp.Value), nil
}

func (b *AKV) List(ctx context.Context, _ *Profile) ([]Key, error) {
pager := b.client.NewListSecretsPager(nil)
pager := b.client.ListPropertiesOfSecrets(nil)

var keys []Key
for pager.More() {
Expand All @@ -31,11 +32,10 @@ func (b *AKV) List(ctx context.Context, _ *Profile) ([]Key, error) {
return nil, err
}

for _, each := range page.Value {

for _, v := range page.Secrets {
keys = append(keys, Key{
Name: each.ID.Name(),
CreatedAt: *each.Attributes.Created,
Name: *v.Name,
CreatedAt: *v.Properties.CreatedOn,
Info: "creator: <Unknown>", // no owner
Owner: "<Unknown>",
})
Expand All @@ -45,31 +45,34 @@ func (b *AKV) List(ctx context.Context, _ *Profile) ([]Key, error) {
}

func (b *AKV) CheckExists(ctx context.Context, _ *Profile, key string) (bool, error) {
_, err := b.client.GetSecret(ctx, key, "", nil)
_, err := b.client.GetSecret(ctx, key, nil)
return err == nil, err
}

func (b *AKV) Put(ctx context.Context, _ *Profile, key, value string, overwrite bool) error {
params := azsecrets.SetSecretParameters{Value: &value}
_, err := b.client.SetSecret(ctx, key, params, nil)
_, err := b.client.SetSecret(ctx, key, value, nil)
if err != nil {
return err
}
return nil
}

func (b *AKV) Delete(ctx context.Context, _ *Profile, key string) error {
_, err := b.client.DeleteSecret(ctx, key, nil)
res, err := b.client.BeginDeleteSecret(ctx, key, nil)
if err != nil {
return err
}
_, err = res.PollUntilDone(ctx, time.Second)
if err != nil {
return err
}
return nil
}

func (b *AKV) Close() error {
return nil
func (b *AKV) SetParameter(key string, value interface{}) {
//no-op
}

func (b *AKV) SetParameter(key string, value interface{}) {
// noop
func (b *AKV) Close() error {
return nil
}

0 comments on commit 007e3d9

Please sign in to comment.