Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add light controller for Tolino Epos 3 #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dboleslawski
Copy link

@dboleslawski dboleslawski commented Oct 5, 2024

Built a specific light controller for the Tolino Epos 3. The NTX controller does not seem to change the warmth value (I guess without root) and the lighting max value is 255 there while the Epos 3 caps out at 100.

Has been tested now for a few weeks, can confirm it works rock-solid on my device. Only thing that I had to do, is to manually allow "Modify system settings" for KOReader in the Android settings. Not sure if there is supposed to be a Popup when opening the App the first time..


This change is Reviewable

@pazos
Copy link
Member

pazos commented Oct 6, 2024

Thanks for your contribution!

Has been tested now for a few weeks, can confirm it works rock-solid on my device. Only thing that I had to do, is to manually allow "Modify system settings" for KOReader in the Android settings. Not sure if there is supposed to be a Popup when opening the App the first time..

The expected behaviour isn't wired yet as no other driver use it. But you driver correctly declares needsPermission and drivers with that enabled should prompt for the WRITE_SETTINGS permission the first time they're invoked (via light dialog or via gestures)

Give me a few days, since I'm currently busy, to wire up things, so you can test this PR against it and confirm it works correctly without having to enable "Modify system settings" manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants