Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add z to childItemEntity #259

Merged
merged 1 commit into from
May 5, 2023
Merged

feat: Add z to childItemEntity #259

merged 1 commit into from
May 5, 2023

Conversation

Matehoo
Copy link
Contributor

@Matehoo Matehoo commented May 4, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot Indexer.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #5530
  • This PR is required for kodadot/nft-gallery#<issue_number>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've run the indexer and it hasn't failed
  • I've changed schema and performed a migration
  • I found edge cases

Screenshot

  • My contribution is a resolver so I have pic from playground

Screenshot 2023-05-05 at 14 51 32

@vikiival
Copy link
Member

vikiival commented May 5, 2023

cc @Matehoo
Screenshot 2023-05-05 at 14 42 32

vikiival
vikiival reviewed May 5, 2023
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Okish

@Matehoo
Copy link
Contributor Author

Matehoo commented May 5, 2023

cc @Matehoo Screenshot 2023-05-05 at 14 42 32

Screenshot added to description

@vikiival vikiival merged commit 6c58f4b into kodadot:main May 5, 2023
@vikiival vikiival added the V2 Implementation of RMRK::2.0.0 label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

Assignees
No one assigned
Labels
V2 Implementation of RMRK::2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matehoo @vikiival