[TASK-1117] Fix alertify elusive crash when (un)archiving a project from My Projects #5151
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2edwards
reviewed
Oct 7, 2024
| // sometimes when `actions.resources.setDeploymentActive` finishes, | ||
| // the `dialog.destroy` can't find something and crashes with: | ||
| // `Uncaught TypeError: instance.__internal is undefined` | ||
| return false; |
There was a problem hiding this comment.
tested and it works! Just needs to be in the unarchiveAsset function too 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./python-format.shto make sure that your code lints and that you've followed our coding styleNotes
I was able to reproduce the bug sometimes. I no longer can reproduce it now, so I am not sure this PR fixes it. It's an educated guess.
This particular alertify instance has an async function insid
onokcallback, and only then is closing the dialog. But theonokis closing the dialog by default - unless the callback returnsfalse. My guess is that withoutreturn false;alertify was trying to close the dialog and cleanup some inner things. And then the callback was resolved and it also tried to close the dialog. And sometimes this works fine, and sometimes it doesn't - this is my theory 😉