Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for name attribute in XLSForms #5137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajpatel24
Copy link
Contributor

@rajpatel24 rajpatel24 commented Oct 1, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

This update enhances the OpenRosa to support the name attribute specified in XLSForms. Previously, OpenRosa did not honor the name='data' setting, which affected the implementation of custom confirmation messages. By allowing this attribute to be set and recognized, we ensure that users can utilize custom confirmation messages effectively, improving the overall user experience and flexibility of the forms.

Notes

  • Implemented logic to check and set the name attribute from XLSForms in the survey object.
  • The existing behavior where name was not utilized has been modified to honor the name setting, defaulting to the id_string if name is not provided or is invalid.

Related issues

Part of #5112

@rajpatel24 rajpatel24 changed the title Enable support for name attribute in XLSForms to facilitate custom co… Enable support for name attribute in XLSForms Oct 1, 2024
@noliveleger noliveleger closed this Oct 1, 2024
@noliveleger noliveleger reopened this Oct 1, 2024
@noliveleger noliveleger changed the base branch from beta-refactored to kobocat-django-app-part-2 October 3, 2024 23:21
Base automatically changed from kobocat-django-app-part-2 to main October 7, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants