[TASK-1058] Fix registration links #5089 #5090
Open
+55
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloamorimbr
force-pushed
the
5089-fix-registration-links
branch
from
46b33b2
to
1b172e8
Compare
pauloamorimbr
changed the title
p2edwards
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Cool!
@pauloamorimbr During review / edge case testing I made some suggested changes in a separate branch (https://github.com/kobotoolbox/kpi/tree/5089-fix-registration-links--additions):
- Checked what it looks like when an SSO provider is configured — I color-matched the SSO separator with this new links one (went with the new color)
- Fixed a layout issue on signup page on narrow screen width
- Also fixed an unrelated color issue that was introduced recently — changed 'required' asterisks back to light red
- Remove extra separator if the Django admin didn't configure Privacy Policy / Terms links at all
Compare: https://github.com/kobotoolbox/kpi/compare/5089-fix-registration-links..5089-fix-registration-links--additions — (you'd need to merge 'main' into '5089-fix-registration-links' first to see a clean diff)
| +sso | |
|---|---|
Other questions (not included above)
- 🎨 @tesster7 What do you think of these legal link colors/sizes/etc.? I wonder if we'd want them to match more closely with the Create Account / Forgot password or not. The contrast is still a little low imo but maybe want to avoid it being too busy.
sso-specific pages
- 🔧 @pauloamorimbr There are 2 more SSO-related templates (under kpi/kobo/apps/accounts/templates/socialaccount/ — login.html and signup.html) @tinok should we put the Terms / Privacy links here too, or is that not necessary? (the deep signup / login pages that you get if you're using SSO.)
| sso-specific login page | e.g. with legal links |
|---|---|
Comment on lines
+76
to
+87
| <div class="registration__legal"> | ||
| {% if config.TERMS_OF_SERVICE_URL %} | ||
| <a href="{{config.TERMS_OF_SERVICE_URL}}" target="_blank"> | ||
| {% trans "Terms of Service" %} | ||
| </a> | ||
| {% endif %} | ||
| {% if config.PRIVACY_POLICY_URL %} | ||
| <a href="{{config.PRIVACY_POLICY_URL}}" target="_blank"> | ||
| {% trans "Privacy Policy" %} | ||
| </a> | ||
| {% endif %} | ||
| </div> |
There was a problem hiding this comment.
edit: incorporated in the review branch [xref 💬]
Suggest wrapping the div for registration__legal in an inclusive check {% if config.TERMS_OF_SERVICE_URL or config.PRIVACY_POLICY_URL %} to remove this separator line if it's not needed:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Terms of Service and Privacy Policy links are now places inside the darker area to provide better visibility.
Notes
Some changes in the UI were made based on this discussion in Zulip.
Production:
This PR:
Related issues
Fixes #5089