Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new search component - impl hybrid Combobox and NavigationMenu #501

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MengLinMaker
Copy link

@MengLinMaker MengLinMaker commented Oct 16, 2024

Create a search component #504 with inspiration from Combobox and NavigationMenu

  • Input

    • Controlled value via context
    • Placeholder
    • Expose onInput and onChange as props - in root
  • Indicator

    • Wrap onInput to set suggestionLoading state
    • Display suggestionLoading state UI
    • Toggle is suggesting state on/off - indicateSuggestionLoading
  • Menu

    • Export menu item under search
    • displayMenuOption as permanent | onInput | onFocus
    • Trigger search on MenuItem click
  • Keyboard

    • Focus on menu on down + up key from input
    • Focus on input on esc and alpha-numeric key from menu
    • Trigger search on enter or MenuItem
  • Aria - Maybe create functions in separate aria.ts file for clarity

    • Mention text input - fallback to placeholder - fallback to searchbox
    • Mention press enter to select
  • Doc

    • Command bar
    • minisearch engine through emojis
  • Refactor

    • Remove combobox list in favour of menu
    • Group context values to separate features
  • Test

Copy link

netlify bot commented Oct 16, 2024

👷 Deploy request for kobalte pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c4fe83f

@MengLinMaker MengLinMaker changed the title feat(search): start impl feat: new search component - impl hybrid Combobox and NavigationMenu #504 Oct 21, 2024
@MengLinMaker MengLinMaker changed the title feat: new search component - impl hybrid Combobox and NavigationMenu #504 feat: new search component - impl hybrid Combobox and NavigationMenu Oct 21, 2024
@jer3m01 jer3m01 marked this pull request as draft October 21, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant