Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #318.
Updates from Prettier v3 to v4(
4.0.0-alpha.8
) and uses Biome instead for js* files.Reasoning
Mainly to obtain better performances and DX while working on Kobalte.
Code style has been changed from spaces to tabs: rome/tools#425.
Performance
These are for heuristic purposes and are not rigorous enough to stand as proper benchmarks.
Timings are from fish
time
, more info on how to read them here: https://fishshell.com/docs/current/cmds/time.html#how-to-interpret-the-output.Taken on WSL2:
Only ran on files supported both by Prettier and Biome.
Clean repo
Times posted below are running on a already formatted repo (i.e. everything is already formatted and no file writes are required).
Each were run multiple times to check for consistent values.
Initial setup using Prettier v3:
(Originally Prettier v3 also ran on dist files and took up to 70s, most time reduced was by ignoring them)
Updating to Prettier v4:
Prettier v4 no cache:
Prettier v4 no parallel no cache:
Using Biome:
These numbers a much better than original but most of the performance vs Prettier v3 is both gained using Prettier v4 and Biome. Great work Prettier!
Dirty repo
Times posted below are running on a unformatted repo and needs file writes. Both tools have the same starting files to reformat.
Each were run multiple times to check for consistent values.
Prettier v4:
Prettier v4 no parallel no cache:
Biome:
This time the difference is very noticeable and Biome provides an amazing performance increase.