Skip to content

Commit

Permalink
chore: correct type definitions
Browse files Browse the repository at this point in the history
  • Loading branch information
jer3m01 committed Apr 5, 2024
1 parent 361f049 commit 181670d
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 14 deletions.
3 changes: 1 addition & 2 deletions packages/core/src/accordion/accordion-content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ import * as Collapsible from "../collapsible";
import { PolymorphicProps } from "../polymorphic";
import { useAccordionItemContext } from "./accordion-item-context";

export interface AccordionContentOptions
extends Collapsible.CollapsibleContentOptions {}
export interface AccordionContentOptions {}

export interface AccordionContentCommonProps
extends Collapsible.CollapsibleContentCommonProps {
Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/accordion/accordion-item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ import {
AccordionItemContextValue,
} from "./accordion-item-context";

export interface AccordionItemOptions
extends Collapsible.CollapsibleRootOptions {
export interface AccordionItemOptions {
/** A unique value for the item. */
value: string;

Expand Down
5 changes: 2 additions & 3 deletions packages/core/src/accordion/accordion-trigger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

import {
OverrideComponentProps,
callHandler,
composeEventHandlers,
mergeDefaultProps,
Expand All @@ -31,11 +30,11 @@ import { createSelectableItem } from "../selection";
import { useAccordionContext } from "./accordion-context";
import { useAccordionItemContext } from "./accordion-item-context";

export interface AccordionTriggerOptions
extends Collapsible.CollapsibleTriggerOptions {}
export interface AccordionTriggerOptions {}

export interface AccordionTriggerCommonProps
extends Collapsible.CollapsibleTriggerCommonProps {
id: string;
onPointerDown: JSX.EventHandlerUnion<HTMLElement, PointerEvent>;
onPointerUp: JSX.EventHandlerUnion<HTMLElement, PointerEvent>;
onKeyDown: JSX.EventHandlerUnion<HTMLElement, KeyboardEvent>;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/breadcrumbs/breadcrumbs-link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Component, ValidComponent, splitProps } from "solid-js";
import * as Link from "../link";
import { PolymorphicProps } from "../polymorphic";

export interface BreadcrumbsLinkOptions extends Link.LinkRootOptions {
export interface BreadcrumbsLinkOptions {
/** Whether the breadcrumb link represents the current page. */
current?: boolean;
}
Expand Down
4 changes: 1 addition & 3 deletions packages/core/src/checkbox/checkbox-input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@
*/

import {
OverrideComponentProps,
callHandler,
mergeDefaultProps,
mergeRefs,
visuallyHiddenStyles,
} from "@kobalte/utils";
import {
ComponentProps,
JSX,
ValidComponent,
createEffect,
Expand All @@ -39,7 +37,7 @@ export interface CheckboxInputCommonProps {
id: string;
ref: HTMLInputElement | ((el: HTMLInputElement) => void);
/** The HTML styles attribute (object form only). */
style?: JSX.CSSProperties;
style: JSX.CSSProperties;
onChange: JSX.EventHandlerUnion<HTMLInputElement, InputEvent>;
onFocus: JSX.FocusEventHandlerUnion<HTMLInputElement, FocusEvent>;
onBlur: JSX.FocusEventHandlerUnion<HTMLInputElement, FocusEvent>;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/collapsible/collapsible-content.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export interface CollapsibleContentOptions {}
export interface CollapsibleContentCommonProps {
id: string;
ref: HTMLElement | ((el: HTMLElement) => void);
style?: JSX.CSSProperties;
style: JSX.CSSProperties;
}

export interface CollapsibleContentRenderProps
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/collapsible/collapsible-trigger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import * as Button from "../button";
import { PolymorphicProps } from "../polymorphic";
import { useCollapsibleContext } from "./collapsible-context";

export interface CollapsibleTriggerOptions extends Button.ButtonRootProps {}
export interface CollapsibleTriggerOptions{}

export interface CollapsibleTriggerCommonProps
extends Button.ButtonRootCommonProps {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/skeleton/skeleton-root.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export interface SkeletonRootOptions {
export interface SkeletonRootCommonProps {
id: string;
/** The HTML styles attribute (object form only). */
style?: JSX.CSSProperties;
style: JSX.CSSProperties;
}

export interface SkeletonRootRenderProps extends SkeletonRootCommonProps {
Expand Down

0 comments on commit 181670d

Please sign in to comment.