Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example health check #493

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

IngmarStein
Copy link
Contributor

With a check as part of the image, users don't have to configure the checks themselves in a Compose file, for example.

@klutchell
Copy link
Owner

Hey @IngmarStein , this image actually used to have a default health check but it was removed as it caused more issues and confusion than it solved.

In my experience, health checks are best left to those that are defining the runtime via compose, not the image itself. Otherwise the image may fail for environmental reasons with little explanation.

That said, I appreciate the fix in the example compose file so I agree we should merge that part!

@IngmarStein IngmarStein changed the title Add a default health check Update the example health check Sep 16, 2024
@IngmarStein
Copy link
Contributor Author

Alright, I've removed the change to Dockerfile and kept the updated example.

@klutchell klutchell merged commit 1adbf34 into klutchell:main Sep 16, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants