Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add-value-prop-to-dropwdown-cascader #45

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: add-value-prop-to-dropwdown-cascader #45

merged 1 commit into from
Apr 26, 2024

Conversation

Harman-singh-waraich
Copy link
Contributor

@Harman-singh-waraich Harman-singh-waraich commented Apr 26, 2024 •
edited by pr-codex bot
Loading

  • Adds prop value to persist the selected value in Dropdown Cascader

PR-Codex overview

The focus of this PR is to add a new optional prop value to Cascader component and dynamically display the selected label based on the provided value.

Detailed summary

  • Added value prop to ICascader
  • Implemented logic to find label based on value
  • Updated display to show selected label or placeholder

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

alcercu
alcercu approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 0a253bc into main Apr 26, 2024
3 checks passed
@alcercu alcercu deleted the feat/value-prop-dropdown-cascader branch April 26, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harman-singh-waraich @alcercu