Do not jump to first file when using FSA API #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaifroid
added
regression
|
Also works as intended with |
|
Ah, I forgot, I also need to do #1257 as we had agreed. So there will be one more issue-fixing PR after this. |
Jaifroid
deleted the
Do-not-jump-to-first-file-when-using-showDirectoryPicker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1254.
This should be the last of the issue-fixing PRs prior to preparing release of v4.1.
It ensures that a ZIM file is not actually opened if the user selected a directory of archives using the File System Access
window.showDirectoryPicker()method, and if that folder contains more than one archive. Without this fix, the first archive in the directory is inadvertently opened, which is unexpected and potentially insecure behaviour.I need to test whether the same applies to the
webkitdirectorymethod used by Firefox and Edge Legacy.