Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the restriction popup from PS variant which was showing at start. #4010

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Sep 30, 2024

@kelson42 kelson42 added this to the 3.12.0 milestone Sep 30, 2024
@kelson42
Copy link
Collaborator

@MohitMaliFtechiz Can younplease rebase?

@MohitMaliFtechiz
Copy link
Collaborator Author

@MohitMaliFtechiz Can younplease rebase?

@kelson42 Sure.

We have this same message in our help screen, should we remove this from there also? IMO we should improve this message to tell about the restriction(That directly scanning will not work due to Play Store restriction, but you can load your existing zim files via file picker).

Screenshot from 2024-09-30 18-07-55

* Since now we have a way to load the sideloaded zim files in application so this popup does not make sense. Therefore, we are removing this.
@MohitMaliFtechiz MohitMaliFtechiz force-pushed the remove_restriction_popup_from_ps_variant branch from 6072c7a to 4645aa1 Compare September 30, 2024 16:40
@kelson42
Copy link
Collaborator

@MohitMaliFtechiz Can younplease rebase?

@kelson42 Sure.

We have this same message in our help screen, should we remove this from there also? IMO we should improve this message to tell about the restriction(That directly scanning will not work due to Play Store restriction, but you can load your existing zim files via file picker).

Screenshot from 2024-09-30 18-07-55

yes please

…lay Store variant. Informed users that they can load existing ZIM files via the file picker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants