-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a donation popup to our application. #3984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Popolechien Does the approqch sounds correct to you? |
Yup very good |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
============================================
- Coverage 57.76% 57.46% -0.31%
- Complexity 1575 1587 +12
============================================
Files 311 312 +1
Lines 12865 12960 +95
Branches 1641 1651 +10
============================================
+ Hits 7432 7447 +15
- Misses 4341 4422 +81
+ Partials 1092 1091 -1 ☔ View full report in Codecov by Sentry. |
MohitMaliFtechiz
force-pushed
the
Fixes#3736
branch
from
September 6, 2024 16:14
caca80f
to
0631a37
Compare
* The donation popup will be shown to the user every three months. * If the user clicks the "Later" button, the popup will appear again after 3 days. * The donation popup will only be shown when there is at least one book available in the library. If no ZIM file is present, it’s not ideal to ask for a donation, as the user has not yet used the application. * The donation popup will only be shown for custom apps when the support_url is configured. If the support menu item is hidden in the sidebar (a feature we offer), the donation popup will not be displayed, as there is no support_url available for that custom app.
…pBar showing in the reader.
MohitMaliFtechiz
force-pushed
the
Fixes#3736
branch
from
September 9, 2024 06:59
0631a37
to
8f2372b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3736