This repository has been archived by the owner on Aug 28, 2018. It is now read-only.
Use Symfony property accesor #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm all for it! Much better this way. |
| @@ -15,7 +15,8 @@ | |||
| "doctrine/data-fixtures": "1.*@alpha", | |||
| "doctrine/doctrine-fixtures-bundle": "2.*@alpha", | |||
| "doctrine/orm": "2.*", | |||
| "doctrine/doctrine-bundle": "*" | |||
| "doctrine/doctrine-bundle": "*", | |||
| "symfony/property-access": "~2.3" | |||
There was a problem hiding this comment.
Isn't this going to block you on the 2.3 branch where we'd actually probably want 2.* ?
There was a problem hiding this comment.
no, it's allow all version >= 2.3, i have chosen the 2.3 because 2.2 is deprecated version.
claudusd
force-pushed
the
symfony-property-accessor
branch
from
573c7b2
to
63a30f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I propose to use the symfony property accesor, it's more flexible and now we can use add method for collections.
ping @khepin for code review.