Add support for application kernels which are not named AppKernel #48
Conversation
…fixed some coding-style errors and MongoDB tests in the progress
dsbaars
changed the title
| @@ -14,10 +14,29 @@ protected function configure() | |||
| $this | |||
There was a problem hiding this comment.
Only changing formatting here? Any reason?
|
Why all the format changes? It makes it really difficult to find out where are the actual changes to the code and review them. Also it seems you didn't add a test for your use case. |
|
The format changes makes this bundle adhere to the PHP coding standards (http://symfony.com/doc/2.3/contributing/code/standards.html) Furthermore, the testing code only needed to be modified. See: https://github.com/dsbaars/KhepinYamlFixturesBundle/blob/a13260ccdaada0aa461b7cf2fe8e44b05181d61d/tests/Khepin/Tests/YamlFixtureTest.php#L26 |
Add support for application kernels which are not named AppKernel
|
Alright, thanks for clarification. Sorry for the delay, I am moving to a new country, lots of things to do. I'm adding you to the repo. You'll be able to publish a version if needed. |
Cleaner solution than #33, because it checks on implementation of the KernelInterface.
I also adjusted the tests for this and fixed some MongoDB tests which assumed the return of a cursor, when it was an array.
Also, I improved adherence to the PHP coding standard for some lines of code.