Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing validation when bit was not mapped in dictionary #83

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

brauliorivas
Copy link
Member

BEGINRELEASENOTES

ENDRELEASENOTES

Copy link

github-actions bot commented Aug 28, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-02 11:04 UTC

@tmadlener
Copy link
Contributor

I can see the filter box with this, but I am not sure if the filtering is working as expected, e.g. if I select Overlay and then invert the filter, the particles for which the overlay bit is set are still visible:

image

I am not sure if this is related to the changes here or whether this needs another fix as well.

@brauliorivas
Copy link
Member Author

I am not sure if this is related to the changes here or whether this needs another fix as well.

Yes, it needs another fix. Changes from here aren't related.

@kjvbrt kjvbrt merged commit 3d1af63 into key4hep:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken display for specific files
3 participants