Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV demo + support null fields #67

Merged
merged 5 commits into from
Jan 29, 2024
Merged

CSV demo + support null fields #67

merged 5 commits into from
Jan 29, 2024

Conversation

friendlymatthew
Copy link
Collaborator

@friendlymatthew friendlymatthew commented Jan 26, 2024 •
edited
Loading

What this PR does

We need to append data even including null fields. This meant modifying the handleObject function logic as well as mapping the null value to it's correct protocol.FieldTypeNull value.

  • wrote test to assert claim

  • A demo that uses csv

The following screenshot is the demo from csv data:
Screen Shot 2024-01-26 at 5 17 36 PM

  • some helpful scripts for local development setting

Todo

  • perform the same logic for JSONL
  • add jest tests for formatting CSV line
  • clean up CSV parsing logic

@friendlymatthew friendlymatthew marked this pull request as ready for review January 29, 2024 17:09
@friendlymatthew friendlymatthew merged commit 6e50d4a into kevmo314:main Jan 29, 2024
2 checks passed
kevmo314 pushed a commit that referenced this pull request Feb 5, 2024
@friendlymatthew @kevmo314
CSV demo + support null fields (#67)
d0b22e7 
* support csv, account for null

* cleanup + refactor csv + include jsonl

* cleanup + direct workflow to csv
kevmo314 added a commit that referenced this pull request Feb 5, 2024
@kevmo314 @friendlymatthew
feat: switch to b+ tree (#75)
c8684cc 
* feat: switch to b+ tree

* fixes

* init: csv handler

* coverage: recognize null fields test

* fix: ci

* pass tests

* Add `selectFields` to query language (#71)

* add support fields

* rename + convert to Pick type

* CSV demo + support null fields (#67)

* support csv, account for null

* cleanup + refactor csv + include jsonl

* cleanup + direct workflow to csv

* Add CSV table (#74)

* add csv table

* change to ternary exp

* Add query validation to library (#77)

* add query validation

* refactor

* feat: chain queries (#78)

* feat: chain queries

* refactor

* Coverage: Assert query chain behavior (#79)

* coverage

* memory conservation

---------

Co-authored-by: Matthew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support null fields
1 participant
@friendlymatthew