Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CSV #6

Merged
merged 12 commits into from
Jan 15, 2024
Merged

support CSV #6

merged 12 commits into from
Jan 15, 2024

Conversation

friendlymatthew
Copy link
Collaborator

@friendlymatthew friendlymatthew commented Dec 26, 2023

fixes #4

What this PR does

  • Adds the --jsonl or -csv flags to the CLI.
  • NewIndexFile and extends Synchronize for the csv datahandler
  • Refactor ReadIndexFile to handle various formats
  • Add tests to check byte-identical, checksums between csv Index file <---> csv readIndexFile
  • Add tests to check byte-identical between csv Index file <---> jsonl Index file

@kevmo314
Copy link
Owner

kevmo314 commented Jan 2, 2024

This is a pretty good start. One idea for a test would be to generate the index file and check if it's byte-identical to the index file created by the jsonl version.

Since the taxicab data is relatively primitive types, this should be not too crazy to do.

@friendlymatthew
Copy link
Collaborator Author

friendlymatthew commented Jan 2, 2024

This is a pretty good start. One idea for a test would be to generate the index file and check if it's byte-identical to the index file created by the jsonl version.

Since the taxicab data is relatively primitive types, this should be not too crazy to do.

Hey Kevin,

Sorry about the AWOLness, I've been pretty sick with the flu for the past week. I'm slowly feeling better and will have this feature up soon.

Happy new year 🐉 :)

@kevmo314
Copy link
Owner

kevmo314 commented Jan 2, 2024

No worries, it's the holidays anyways so everything is on higher latency. I also got sick with covid + a cold a two weeks ago so I know how it is, it seems like everyone has been getting sick :)

Happy new year!

@friendlymatthew friendlymatthew changed the title current work: wrote out basic IndexFile creation support CSV Jan 11, 2024
Copy link
Owner

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the tests, makes it super easy to figure out.

pkg/appendable/io.go Outdated Show resolved Hide resolved
pkg/appendable/io.go Show resolved Hide resolved
@friendlymatthew friendlymatthew marked this pull request as ready for review January 15, 2024 23:21
@friendlymatthew friendlymatthew merged commit 79cfb56 into kevmo314:main Jan 15, 2024
2 checks passed
@friendlymatthew friendlymatthew deleted the handle-csv branch January 15, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add csv support
2 participants