Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check in max level for every friend id #369

Merged
merged 2 commits into from
Jul 8, 2024
Merged

feat: check in max level for every friend id #369

merged 2 commits into from
Jul 8, 2024

Conversation

friendlymatthew
Copy link
Collaborator

Per the discord comments about flushing Friends to disk.

DMR till #368

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Benchmark results: https://github.com/kevmo314/appendable/actions/runs/9845632289/artifacts/1679180175

@friendlymatthew
Copy link
Collaborator Author

friendlymatthew commented Jul 8, 2024 •
edited
Loading

@kevmo314 I can't directly respond to your comment, but the Hnsw itself takes in a mapping from every node to it's unique Friends data structure.

Since the entry point is dynamically set, I'm not sure if we can ensure that the node-specific Friends datastructure will store Ids sequentially.

@friendlymatthew friendlymatthew enabled auto-merge (squash) July 8, 2024 19:18
@friendlymatthew friendlymatthew merged commit ada059d into main Jul 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmo314 kevmo314 kevmo314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friendlymatthew @kevmo314