Btree random insertion test #364
Conversation
| // this should be the leaf node | ||
| if int(parent.Size()) > t.PageFile.PageSize() { | ||
| panic("too fat!") | ||
| } |
There was a problem hiding this comment.
When we reach the point where we finally serialize the leaf node post top-down traversal, that leaf size can exceed a page. I was going to split, but is creating an intermediate node with only one element (the mid key) be sufficient?
There was a problem hiding this comment.
Hmm I think splitting while traversing downwards won't work because of this problem. Adding an intermediate node isn't great because there is a degenerate sequence of inserts that will always trigger an intermediate node insertion leading to bad asymptotic performance.
Specifically, right now you're splitting the tree as you're traversing down to the leaf node but instead it might be easier to insert it first and then propagate the split back up the tree. This would fix the issue as you wouldn't need to create an intermediate node.
There was a problem hiding this comment.
Sounds good
No description provided.