Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol and Index_File #31

Closed
wants to merge 6 commits into from
Closed

Protocol and Index_File #31

wants to merge 6 commits into from

Conversation

friendlymatthew
Copy link
Collaborator

Still a draft, I plan on committing frequently for transparency

The first step was to translate protocol.

It should be fairly similar, with the only difference being a custom FieldFlags struct. set() uses bitwise operations to set flags corresponding to different FieldType values.

index_file.rs should be fairly similar to the Go version, with the only difference being the Index struct takes FieldFlag as an attribute.

Also, IndexKey is supposed to account for the any that you see in the Go version.

Copy link
Owner

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction looks good so far.

appendable-rs/appendable/src/tests/jsonl_index_file.rs Outdated Show resolved Hide resolved
appendable-rs/appendable/src/handler/jsonl_handler.rs Outdated Show resolved Hide resolved
appendable-rs/appendable/Cargo.toml Outdated Show resolved Hide resolved
@friendlymatthew
Copy link
Collaborator Author

Going to close this after today's sync.

RIP 🦀

@friendlymatthew friendlymatthew deleted the protocol+indexfile branch February 23, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants