-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Selenium Grid scaler #6169
base: main
Are you sure you want to change the base?
Conversation
5f1a9b5
to
7522f8c
Compare
/run-e2e selenium |
575beb3
to
fa7b01a
Compare
Noted that we also set up some e2e tests in the downstream repo https://github.com/SeleniumHQ/docker-selenium/tree/trunk/.keda for the evaluation and feedback from community |
/run-e2e selenium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is really great, thanks for the contribution!
c4cbaa4
to
4e46487
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
/run-e2e selenium |
Provide a description of what has been changed
nodeMaxSessions
(default is 1), to configure the scaler to be aligned with option--max-sessions
(env varSE_NODE_MAX_SESSIONS
) in the Node. It helps the calculation be better.Checklist
Fixes #6144 Fixes #6080
Relates to SeleniumHQ/docker-selenium#2160, SeleniumHQ/docker-selenium#1925, #6047