Fix typo and reuse predefined value #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Signed-off-by: Yoon Park <[email protected]>
Signed-off-by: Yoon Park <[email protected]>
yoongon
force-pushed
the
feature/typo-then
branch
from
54e800c
to
d9c88aa
Compare
|
/skip-e2e |
|
some checks didnt pass, but I don't think it's related with this change. Please let me know, if something is missing :) |
zroubalik
approved these changes
Jul 3, 2023
|
@JorTurFer @zroubalik I presume we can skip semgrep |
|
it's not Semgrep, it's the e2e tests check. IDK why, even though we create it in other check, it randomly appears... |
|
/skip-e2e |
|
/skip-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes #
Relates to #