fix: test cases

Signed-off-by: Souyama Debnath <[email protected]>
kedacore · Jul 15, 2023 · 8efb8b0 · 8efb8b0
1 parent 6b0c624
commit 8efb8b0
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 36 deletions.
diff --git a/pkg/scalers/kafka_x_scaler.go b/pkg/scalers/kafka_x_scaler.go
@@ -200,6 +200,8 @@ func parseKafkaXAuthParams(config *ScalerConfig, meta *kafkaXMetadata) error {
 			}
 		case KafkaSASLTypeOAuthbearer:
 			return errors.New("SASL/OAUTHBEARER is not implemented yet")
+		default:
+			return fmt.Errorf("err sasl type %q given", mode)
 		}
 	}
 
@@ -338,6 +340,8 @@ func getKafkaXClient(metadata kafkaXMetadata, logger logr.Logger) (*kafka.Client
 	}
 
 	switch metadata.saslType {
+	case KafkaSASLTypeNone:
+		saslMechanism = nil
 	case KafkaSASLTypePlaintext:
 		saslMechanism = plain.Mechanism{
 			Username: metadata.username,
@@ -364,6 +368,8 @@ func getKafkaXClient(metadata kafkaXMetadata, logger logr.Logger) (*kafka.Client
 			Signer: sigv4.NewSigner(config.Credentials),
 			Region: metadata.awsRegion,
 		}
+	default:
+		return nil, fmt.Errorf("err sasl type %q given", metadata.saslType)
 	}
 
 	transport := &kafka.Transport{