Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the metrics-server namespace #657

Closed
wants to merge 1 commit into from

Conversation

fernandezcuesta
Copy link

@fernandezcuesta fernandezcuesta commented Jun 28, 2024

Add the ability to customize where metrics-server is installed, rather than default kube-system, so the roleBinding is created accordingly.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #645

Signed-off-by: Jesús Fernández <[email protected]>
@fernandezcuesta fernandezcuesta requested a review from a team as a code owner June 28, 2024 13:30
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Please revert the changes related with new version (we ship them manually) and update the chart readme (https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#documentation)

@@ -21,7 +21,7 @@ $ helm repo add kedacore https://kedacore.github.io/charts
$ helm search repo kedacore
NAME CHART VERSION APP VERSION DESCRIPTION
kedacore/external-scaler-azure-cosmos-db 0.1.0 0.1.0 Event-based autoscaler for Azure Cosmos DB chan...
kedacore/keda 2.14.2 2.14.0 Event-based autoscaler for workloads on Kubernetes
kedacore/keda 2.14.3 2.14.0 Event-based autoscaler for workloads on Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change please

@@ -8,7 +8,7 @@ kubeVersion: ">=v1.23.0-0"

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 2.14.2
version: 2.14.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change please

@@ -277,6 +277,8 @@ rbac:

# -- Whether RBAC for configured CRDs that can have a `scale` subresource should be created
enabledCustomScaledRefKinds: true
# -- Customize the namespace for metrics-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should highlight this is Kubernetes Metrics Server and not KEDA Metrics Server

@zroubalik
Copy link
Member

Duplicate of #674

@zroubalik zroubalik marked this as a duplicate of #674 Sep 24, 2024
@zroubalik zroubalik closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow metrics-server non-kube-system RBAC (+ClusterRole) deployment
3 participants