fix(add-on): Allow upgrades removing version labels from selectors #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
tomkerkhove
approved these changes
Apr 5, 2024
QuentinBisson
pushed a commit
to giantswarm/keda-upstream
that referenced
this pull request
Jul 1, 2024
…edacore#612) * fix(add-on): Allow upgrades removing version labels from selectors Signed-off-by: Jorge Turrado <[email protected]> * add note Signed-off-by: Jorge Turrado <[email protected]> --------- Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matchLabelsin the HTTP Add-on are wrong because they include version information butmatchLabelsis inmutable, so the upgrades are blocked due to this. The PR adjust thematchLabelsto just the only ones which doesn't change across the versions.Checklist
Fixes kedacore/http-add-on#656