Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Travis-CI with GitHub Actions. #2

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dblock
Copy link

@dblock dblock commented Jun 22, 2024

I'm using kaminari-grape in https://github.com/dblock/slack-gamebot and hit #1. Attempting to revive CI here.

I tried to lock back down to older versions of gems to get a baselines, but can't get CI to pass. This is coming from Kaminari proper, so not sure why.

========================================================================================================================================================================================================================================================================================================================================================
Error: test: #param_name(PaginatorHelperTest): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:44:in `block in <class:PaginatorHelperTest>'
========================================================================================================================================================================================================================================================================================================================================================
E
========================================================================================================================================================================================================================================================================================================================================================
Error: test: when params has form params(PaginatorHelperTest::#params): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:38:in `block (2 levels) in <class:PaginatorHelperTest>'
========================================================================================================================================================================================================================================================================================================================================================
E
========================================================================================================================================================================================================================================================================================================================================================
Error: test: when params has no form params(PaginatorHelperTest::#params): ArgumentError: wrong number of arguments (given 2, expected 1)
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/tags.rb:19:in `initialize'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `new'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/lib/kaminari/helpers/paginator.rb:57:in `page_tag'
/Users/dblock/.rvm/gems/ruby-3.2.1/bundler/gems/kaminari-02b179af444d/kaminari-core/test/helpers/helpers_test.rb:30:in `block (2 levels) in <class:PaginatorHelperTest>'
=====================================================================================================================================================================================

Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
@yuki24
Copy link
Member

yuki24 commented Jun 22, 2024

Thanks for this! (also, hi 👋)

Looking at .travis.yml the test suite has not been run in CI at all. I'll look into it tomorrow and see if I can run it locally and try to get it working.

@dblock
Copy link
Author

dblock commented Jun 22, 2024

You can see the GHA being run in my fork, https://github.com/dblock/kaminari-grape/actions, they fail as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants