Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding customization for "events" processing to Http client #2320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quinnjr
Copy link
Contributor

@quinnjr quinnjr commented Oct 24, 2024

Checklist:

  • If this PR is a new feature, please reference a discussion where a consensus about the design
    was reached (not necessary for small changes)
  • Make sure all the significant new logic is covered by tests

About

Creating the ability to define in each request on the context input the different kinds of underlying Angular HttpClient options.

It is primarily suited to adding support for watching and 'event' of the HttpClient to determine events being emitted by the HttpClient as it processes the request/response.

Had to add the coercion of the FetchResult type to the SubscriptionResult type in subscription.ts or else Typescript was throwing errors for it.

Copy link

changeset-bot bot commented Oct 24, 2024

⚠️ No Changeset found

Latest commit: aee1c2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant