Documented TLS Authentication with node https.Agent #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good docs and I was looking for those. I do have to comment that I don't really like how this is done via |
silverwind
reviewed
Apr 17, 2024
| import * as fs from 'fs' | ||
|
|
||
| const agent = new Agent({ | ||
| ca: [ fs.readFileSync('/path/to/yourca.crt', 'utf-8') ], |
There was a problem hiding this comment.
Seems unnecessary to wrap in [] because it accepts both string or string[]. The same thing is in kafkajs docs, but I think unnecessary there as well.
There was a problem hiding this comment.
I can confirm it works just as well without the [].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I open this PR because I found a bit hard to configure TLS authentication against a Schema Registry that accept just this kind of authentication method. I hope that with this integration in the documentation people won't have the same problem (here an old issue raised on this topic #61 ).
Please tell me if you want me to add tests also.