Add iprequests attributes 1.22 #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds attributes to the spec: - spec.IPRequests: user can specify the IP address for an interface - status.Conditions: controller can report success / errors while reserving IP addresses for a workload - status.OwnerPod: controller reports which pod owns the allocation The first two conditions are used to support a feature where the user indicates ahead of time which IP address they want their VMs to have, while the latter can be used to provide information to the user, and to ensure that a claim in use cannot be used by another workload. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
This required the `go generate` targets to be adapted to use the new API. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
The provide cmd had to be updated to comply with the validations introduced in this PR. Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
add-iprequests-attributes-1.22
branch
3 times, most recently
from
7019f44
to
b942967
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
add-iprequests-attributes-1.22
branch
from
b942967
to
36b122e
Compare
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally against a kind kube-1.31 cluster.
Depends-on: #7