Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli commands rework/click #227

Merged
merged 9 commits into from
Apr 19, 2020

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Apr 19, 2020

closes ##220
causes #226

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #227 into master will decrease coverage by 1.72%.
The diff coverage is 14.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   78.46%   76.73%   -1.73%     
==========================================
  Files          22       22              
  Lines        1091     1023      -68     
  Branches      128      117      -11     
==========================================
- Hits          856      785      -71     
- Misses        214      217       +3     
  Partials       21       21              
Impacted Files Coverage Δ
nichtparasoup/_internals/__init__.py 60.00% <ø> (+7.16%) ⬆️
nichtparasoup/cli/__init__.py 0.00% <0.00%> (ø)
nichtparasoup/cli/completion.py 0.00% <0.00%> (ø)
nichtparasoup/commands/imagecrawler_desc.py 0.00% <0.00%> (ø)
nichtparasoup/commands/imagecrawler_list.py 0.00% <0.00%> (ø)
nichtparasoup/commands/server_config_check.py 0.00% <0.00%> (ø)
...htparasoup/commands/server_config_dump_defaults.py 0.00% <0.00%> (ø)
nichtparasoup/commands/server_run.py 0.00% <0.00%> (ø)
nichtparasoup/imagecrawler/__init__.py 98.52% <ø> (ø)
nichtparasoup/config/__init__.py 70.83% <100.00%> (+0.62%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4add0...d3afcb8. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jkowalleck jkowalleck merged commit e7d80e6 into k4cg:master Apr 19, 2020
@jkowalleck jkowalleck deleted the cli_commands_rework/click branch June 27, 2020 08:26
@jkowalleck jkowalleck restored the cli_commands_rework/click branch June 27, 2020 08:27
@jkowalleck jkowalleck deleted the cli_commands_rework/click branch October 10, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant