Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-1.28] Add user path to runtimes search #11005

Merged
merged 1 commit into from
Oct 8, 2024
+3 −3
Merged

[Release-1.28] Add user path to runtimes search #11005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/agent/containerd/config_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (

const (
socketPrefix = "unix://"
runtimesPath = "/usr/local/nvidia/toolkit:/opt/kwasm/bin:/usr/sbin:/usr/local/sbin:/usr/bin:/usr/local/bin"
runtimesPath = "/usr/local/nvidia/toolkit:/opt/kwasm/bin"
)

func getContainerdArgs(cfg *config.Node) []string {
Expand Down Expand Up @@ -55,10 +55,10 @@ func SetupContainerdConfig(cfg *config.Node) error {
cfg.AgentConfig.Systemd = !isRunningInUserNS && controllers["cpuset"] && os.Getenv("INVOCATION_ID") != ""
}

// set the path to include the runtimes and then remove the aditional path entries
// set the path to include the default runtimes and remove the aditional path entries
// that we added after finding the runtimes
originalPath := os.Getenv("PATH")
os.Setenv("PATH", runtimesPath)
os.Setenv("PATH", runtimesPath+string(os.PathListSeparator)+originalPath)
extraRuntimes := findContainerRuntimes()
os.Setenv("PATH", originalPath)

Expand Down
Loading