Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade to Leptos 0.5 #78

Closed
wants to merge 2 commits into from
Closed

WIP: Upgrade to Leptos 0.5 #78

wants to merge 2 commits into from

Conversation

srid
Copy link
Collaborator

@srid srid commented Oct 2, 2023 •
edited
Loading

Resolves #77

  • Fix hydration regressions
  • Refactor
    • New <For> with children
    • Remove arguments from #[server] macro

@srid srid mentioned this pull request Oct 2, 2023
Closed
@srid
Copy link
Collaborator Author

srid commented Oct 2, 2023 •
edited
Loading

Alas, seeing hydration errors:

image

Now go to a page, say http://127.0.0.1:3000/health, and reload the browser tab:

image

EDIT: seems to involve leptos_query (which we won't use after #59 anyway)

Full log:

127.0.0.1-1696259084227.log

Relevant:

$leptos_query::use_query::use_query::{{closure}}::h091be41f3a9398e6 @ nix-browser.wasm:0xd2ac6

@srid srid mentioned this pull request Oct 2, 2023
Merged
@srid srid changed the title Upgrade to Leptos 0.5 WIP: Upgrade to Leptos 0.5 Oct 2, 2023
@srid
Copy link
Collaborator Author

srid commented Oct 2, 2023

Might as well wait for next release: leptos-rs/leptos#1830

@srid srid marked this pull request as draft October 2, 2023 22:31
@srid
Copy link
Collaborator Author

srid commented Oct 10, 2023

We are going with Dioxus #79

@srid srid closed this Oct 10, 2023
@srid srid deleted the leptos05 branch October 12, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to leptos 0.5
1 participant
@srid