Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Touch Events #123

Merged
merged 9 commits into from
Sep 30, 2021
Merged

Basic Touch Events #123

merged 9 commits into from
Sep 30, 2021

Commits on Sep 7, 2020

  1. feat(touch): Add basic touch support to tabbar 🚸 

    Helps with #77
    @bign8
    bign8 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    0014b5d View commit details
    Browse the repository at this point in the history

  2. refactor(touch): Expose convertTouchToMouseEvent for DRY ♻️

    @bign8
    bign8 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    a2ad28a View commit details
    Browse the repository at this point in the history

  3. feat(touch): Add touch resize handlers ☝️

    @bign8
    bign8 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    04c630c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. test(touch): verify touch to mouse conversion ✅

    @bign8
    bign8 committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c5b8e68 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Merge branch 'master' of github.com:jupyterlab/lumino into touch-events 

    Conflicts:
	packages/dragdrop/src/index.ts
	packages/dragdrop/tests/src/index.spec.ts
	packages/widgets/src/dockpanel.ts
	packages/widgets/src/tabbar.ts
    @bign8
    bign8 committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    df3b286 View commit details
    Browse the repository at this point in the history

  2. remove eslint exceptions

    @bign8
    bign8 committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    2432f56 View commit details
    Browse the repository at this point in the history

  3. Use PointerEvents instead of TouchEvents 

    Recommended by: @afshin on #123

Found native browser drag/drop inadvertently firing the pointercancel event.
Disabled with css `pointer-events: none` on tabs.

Details: https://javascript.info/pointer-events#event-pointercancel
    @bign8
    bign8 committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    5135519 View commit details
    Browse the repository at this point in the history

  4. Restoring MouseEvents (marked as deprecated) 

    The simulate-event package does not support pointer events.

Looks to be reported here: blakeembrey/simulate-event#3
    @bign8
    bign8 committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    3754c7b View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Merge branch 'master' of oss-github.com:jupyterlab/lumino into touch-… 

    …events
    Steven Silvester committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0aad95b View commit details
    Browse the repository at this point in the history