api update

jupyterlab · Jan 4, 2024 · f013646 · f013646
1 parent a747e97
commit f013646
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/review/api/application.api.md b/review/api/application.api.md
@@ -17,8 +17,6 @@ export class Application<T extends Widget = Widget> {
     activatePlugin(id: string): Promise<void>;
     protected addEventListeners(): void;
     protected attachShell(id: string): void;
-    get bubblingKeydown(): boolean;
-    set bubblingKeydown(value: boolean);
     readonly commands: CommandRegistry;
     readonly contextMenu: ContextMenu;
     deactivatePlugin(id: string): Promise<string[]>;

diff --git a/review/api/widgets.api.md b/review/api/widgets.api.md
@@ -180,7 +180,6 @@ export class CommandPalette extends Widget {
     handleEvent(event: Event): void;
     get inputNode(): HTMLInputElement;
     get items(): ReadonlyArray<CommandPalette.IItem>;
-    // (undocumented)
     readonly keyToText: CommandPalette.IRenderer['keyToText'];
     protected onActivateRequest(msg: Message): void;
     protected onAfterDetach(msg: Message): void;
@@ -237,7 +236,6 @@ export namespace CommandPalette {
         renderer?: IRenderer;
     }
     export interface IRenderer {
-        // (undocumented)
         keyToText?: {
             [key: string]: string;
         };
@@ -256,7 +254,6 @@ export namespace CommandPalette {
         formatItemCaption(data: IItemRenderData): h.Child;
         formatItemLabel(data: IItemRenderData): h.Child;
         formatItemShortcut(data: IItemRenderData): h.Child;
-        // (undocumented)
         keyToText?: {
             [key: string]: string;
         };
@@ -707,6 +704,7 @@ export class Menu extends Widget {
     handleEvent(event: Event): void;
     insertItem(index: number, options: Menu.IItemOptions): Menu.IItem;
     get items(): ReadonlyArray<Menu.IItem>;
+    readonly keyToText: Menu.IRenderer['keyToText'];
     get leafMenu(): Menu;
     get menuRequested(): ISignal<this, 'next' | 'previous'>;
     protected onActivateRequest(msg: Message): void;
@@ -765,6 +763,9 @@ export namespace Menu {
         readonly onfocus?: () => void;
     }
     export interface IRenderer {
+        keyToText?: {
+            [key: string]: string;
+        };
         renderItem(data: IRenderData): VirtualElement;
     }
     export type ItemType = 'command' | 'submenu' | 'separator';
@@ -777,6 +778,9 @@ export namespace Menu {
         formatShortcut(data: IRenderData): h.Child;
         // (undocumented)
         formatShortcutText(data: IRenderData): h.Child;
+        keyToText?: {
+            [key: string]: string;
+        };
         renderIcon(data: IRenderData): VirtualElement;
         renderItem(data: IRenderData): VirtualElement;
         renderLabel(data: IRenderData): VirtualElement;