Add alt attirbutes for test docs sprint #10670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
tonyfast
reviewed
Jul 21, 2021
tonyfast
reviewed
Jul 21, 2021
MarsBarLee
reviewed
Jul 21, 2021
tonyfast
reviewed
Jul 21, 2021
tonyfast
reviewed
Jul 21, 2021
Co-authored-by: Tony Fast <[email protected]>
Co-authored-by: Tony Fast <[email protected]>
Co-authored-by: MarsBarLee <[email protected]> Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Tony Fast <[email protected]> Co-authored-by: MarsBarLee <[email protected]>
|
The sprint went well and we got some great feedback that will be helpful for running this event at a larger scale. This is a first pass on the alt text of these files, and I figure adding some alt text is better than none while we are in the midst of planning the larger event. I am not sure how to resolve the Check Release test failing. |
krassowski
reviewed
Jul 23, 2021
That test had broken for a bit yesterday, all green now! |
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
krassowski
approved these changes
Jul 23, 2021
|
@meeseeksdev please backport to 3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jul 24, 2021
blink1073
pushed a commit
that referenced
this pull request
Jul 24, 2021
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is does not address any existing issues that I am aware of. Sprinting to add alt text to documentation has been mentioned in the weekly team meetings and jupyter/accessibility.
Code changes
Adds alt attributes to images under
CHANGELOG.md,interface.rst, andfiles.rst.User-facing changes
Images in the docs under
CHANGELOG.md,interface.rst, andfiles.rstwill have descriptions. Alt text supports users who use screen readers as well as those that do not.Backwards-incompatible changes
None! ✨