Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add pypi classifiers (#174)" #175

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Revert "Add pypi classifiers (#174)" #175

merged 4 commits into from
Aug 12, 2021

Conversation

fcollonval
Copy link
Member

fcollonval referenced this pull request Aug 11, 2021
@fcollonval
Add pypi classifiers (#174)
fe5889e
@bollwyvl
Copy link
Contributor

Thanks: yeah, we should get them out of there, as this one doesn't even need to be released to break peoples' workflows...

@bollwyvl bollwyvl self-requested a review August 12, 2021 01:27
bollwyvl
bollwyvl approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could just comment this out, but as this is already done, LGTM

@fcollonval
Copy link
Member Author

we could just comment this out, but as this is already done, LGTM

Indeed it will allow user to be informed that new classifiers are coming. Thanks for the suggestion.

@fcollonval fcollonval marked this pull request as ready for review August 12, 2021 06:34
@fcollonval fcollonval merged commit b4ff3cf into jupyterlab:3.0 Aug 12, 2021
@fcollonval fcollonval deleted the revert-classifiers branch August 12, 2021 06:56
@krassowski krassowski mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollwyvl bollwyvl bollwyvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @bollwyvl