Fix escaping issue when escape_userdn and allowed_groups are configured #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
consideRatio
changed the title
consideRatio
force-pushed
the
pr/fix-double-escaping
branch
2 times, most recently
from
3414095
to
fadbf27
Compare
consideRatio
force-pushed
the
pr/fix-double-escaping
branch
from
fadbf27
to
6fc4e5f
Compare
|
Closing this in favor of #267. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this a bug being fixed, but I'm not 100% sure. It is discussed in #243 (comment). I think it should be an improvement though because it ensure we don't double-escape something.
I also think this enables:
Review help greatly appreciated @hammadab @Nikolai-Hlubek @m-erhardt, I've written this PR in the dark here without testing the change etc. Note that test failures for JupyterHub 5 are unrelated and to be resolved separately.