-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manager for tracking and terminating running server proxies #395
base: main
Are you sure you want to change the base?
Commits on Apr 27, 2023
-
It keeps simpervisor proc objects in internal state to be able to teminate a process by calling terminate method on proc object. It also checks the status of active processes by running a periodic callback. If a process is killed outside of jsp, it removes it from running apps list.
Configuration menu - View commit details
-
Copy full SHA for dc8d4c9 - Browse repository at this point
Copy the full SHA dc8d4c9View commit details -
Add API handlers to list&del servers from manager
Existing servers-info endpoint is moved with api sub directory to have a consistent end point scheme.
Configuration menu - View commit details
-
Copy full SHA for 8351275 - Browse repository at this point
Copy the full SHA 8351275View commit details -
Add proxy app to manager upon starting
We also check if proxy is "running" and if it is not, we remove proc object to restart the proxy. This way proxy will be restarted only when user does it via lancher.
Configuration menu - View commit details
-
Copy full SHA for 34a0cba - Browse repository at this point
Copy the full SHA 34a0cbaView commit details -
This manager will be added to running sessions widget so that user can view and terminate running server proxy apps. Proxy app metadata will be shown when we hover over proxy app name.
Configuration menu - View commit details
-
Copy full SHA for 6b743c9 - Browse repository at this point
Copy the full SHA 6b743c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9be248 - Browse repository at this point
Copy the full SHA d9be248View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c6cd9a - Browse repository at this point
Copy the full SHA 3c6cd9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38fc180 - Browse repository at this point
Copy the full SHA 38fc180View commit details -
Configuration menu - View commit details
-
Copy full SHA for f540620 - Browse repository at this point
Copy the full SHA f540620View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3719188 - Browse repository at this point
Copy the full SHA 3719188View commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for 5bab31e - Browse repository at this point
Copy the full SHA 5bab31eView commit details
Commits on Apr 28, 2023
-
Rework manager based on PR comments
Do not instantiate manager in the file anymore. This will be done during extension loading Rework monitoring for proxy apps natively using asyncio. This will be added as callback to ServerApp IO loop during extension loading Manager spits out logs in debug mode when there is proxy app is added/removed from it. Added uni_socket to server proxy app dataclass Remove unnecessary async methods Properly handle the get_server_proxy_{app,proc} methods when server proxy is not found in the manager. We return a default ServerProxyApp tuple in this case with empty values
Configuration menu - View commit details
-
Copy full SHA for d1653d1 - Browse repository at this point
Copy the full SHA d1653d1View commit details -
An OpenAPI spec file is added to keep track of APIs for better maintainability All APIs are moved into /server-proxy/ subdirectory. Seems like root / is used by jupyter_server and /lab/ is used by jupyterlab_server. Moving all APIs under /server-proxy will future incompatibilities Initialise ServersAPIHandler with manager instead of importing it Use a function to setup API handlers which can be called directly during extension loading
Configuration menu - View commit details
-
Copy full SHA for 6f30064 - Browse repository at this point
Copy the full SHA 6f30064View commit details -
Instantiate manager during extension loading
We add manager as a traitlet to ServerApp and add monitor as a callback to ServerApp IO lopp Simplify API handlers setup
Configuration menu - View commit details
-
Copy full SHA for f69a67a - Browse repository at this point
Copy the full SHA f69a67aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97ce111 - Browse repository at this point
Copy the full SHA 97ce111View commit details -
Configuration menu - View commit details
-
Copy full SHA for dafd671 - Browse repository at this point
Copy the full SHA dafd671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 900493b - Browse repository at this point
Copy the full SHA 900493bView commit details -
Rework labextension based on PR comments
Move RunningServerProxyApp to a separate file Use lab transalation capabilities for complex strings Use URLExt package to manipulate URLs
Configuration menu - View commit details
-
Copy full SHA for c54b956 - Browse repository at this point
Copy the full SHA c54b956View commit details -
Use configurable refreshInterval for polling
Use lumino polling class for polling server proxy apps Add schema to be able to configure refreshInterval
Configuration menu - View commit details
-
Copy full SHA for 4738d04 - Browse repository at this point
Copy the full SHA 4738d04View commit details -
Configuration menu - View commit details
-
Copy full SHA for a778a0f - Browse repository at this point
Copy the full SHA a778a0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86d0ad9 - Browse repository at this point
Copy the full SHA 86d0ad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd966ca - Browse repository at this point
Copy the full SHA bd966caView commit details -
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
Configuration menu - View commit details
-
Copy full SHA for bb68e2b - Browse repository at this point
Copy the full SHA bb68e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ffe4f6 - Browse repository at this point
Copy the full SHA 4ffe4f6View commit details
Commits on Sep 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f25996b - Browse repository at this point
Copy the full SHA f25996bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8987c54 - Browse repository at this point
Copy the full SHA 8987c54View commit details