Complete rename of the project - from jupyter_desktop/jupyter-desktop-server to jupyter_remote_desktop_proxy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I checked an sdist and it looks ok: I'll make a PyPI release + a git tag once this is merged, and open a PR with installation instructions (which should help address part of #12) |
yuvipanda
force-pushed
the
complete-rename
branch
from
8f94ed4
to
2c8e7a1
Compare
|
|
|
I'm on mobile, but a big plus for the change idea! |
|
Install instructions PR at #21 |
consideRatio
changed the title
consideRatio
approved these changes
Jan 14, 2023
There was a problem hiding this comment.
Since this change is breaking I'll not go for a merge right now but let @manics or someone else review as well.
consideRatio
changed the title
|
|
|
I've created a new PyPI project that and invited you as owners @yuvipanda @manics. I've also added jupyterhub-bot as a maintainer and generated a token setup as env variable for GitHub actions to use when publishing. |
The package and everything was still being called jupyter_desktop, rather than jupyter_remote_desktop_proxy. This PR renames the package, and bumps the version number so we can make a release to PyPI.
yuvipanda
force-pushed
the
complete-rename
branch
from
5e57af2
to
ee28879
Compare
|
|
|
Rebased after I merged the other PR. |
|
@consideRatio can you invite me again? The previous one expired. I'll merge and make a release tomorrow if there are no objections. |
Merged
|
Done @yuvipanda! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package and everything was still being called jupyter_desktop, rather than jupyter_remote_desktop_proxy. This PR renames the package, and bumps the version number so we can make a release to PyPI.
EDIT by Erik
This package was named
jupyter-desktop-serveron PyPI, andjupyter_desktopas a Python module when installing the PyPI package. Following this change, we are going forjupyter_remote_desktop_proxyas a Python module with the PyPI packagejupyter-remote-desktop-proxy.