"Close and Shut Down Notebook" shuts down without the confirmation dialog #7384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thanks for addressing the surprising behavior of the dialog. I've opened the above feature request to restore the confirmation dialog. From the perspective of a user, I'm not very concerned with consistency with Notebook 6, but I am very concerned with inadvertently losing the work I have in the kernel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7359.
In Notebook 6 and nbclassic, the option "Close and Shut Down Notebook" (no ellipsis) in the File menu shuts the current notebook's kernel down immediately, and closes the browser window/tab. In Notebook 7, we had been using the JupyterLab "Close and Shut Down Notebook…" (with ellipsis) command, which causes a dialog to appear. In the interest of NB6 feature parity and consistency with the File menu's command name, this does not ask for additional confirmation before closing the notebook.