Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grayout "Edit Notebook Metadata" for other file formats. #7265

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

itsmevichu
Copy link
Contributor

Issue No. #7264

Copy link
Contributor

Binder 👈 Launch a Binder on branch itsmevichu/notebook/grayout-edit-notebook-metadata

@@ -549,6 +549,7 @@ const editNotebookMetadata: JupyterFrontEndPlugin<void> = {
});
}
},
isEnabled: () => shell.currentWidget !== null && shell.currentWidget instanceof NotebookPanel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need adding some new lines to satisfy linter.
I would consider going as far as hiding it altogether (isVisible?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will incorporate the changes.

@jtpio jtpio added this to the 7.1.x milestone Feb 19, 2024
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit f9bddf9 into jupyter:main Feb 19, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants