Update index.ts to fix the issue #7090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @navdeepgill14 for looking into this 👍
Looks like this is still an issue on Binder? This is what it looks like when trying the Binder for this PR: https://mybinder.org/v2/gh/navdeepgill14/notebook/main?urlpath=tree
|
jtpio
reviewed
Oct 5, 2023
| @@ -411,8 +411,9 @@ const tabIcon: JupyterFrontEndPlugin<void> = { | |||
| requires: [INotebookTracker], | |||
| activate: (app: JupyterFrontEnd, tracker: INotebookTracker) => { | |||
| // the favicons are provided by Jupyter Server | |||
| const notebookIcon = ' /static/favicons/favicon-notebook.ico'; | |||
| const busyIcon = ' /static/favicons/favicon-busy-1.ico'; | |||
| const baseURL = window.location.origin; | |||
There was a problem hiding this comment.
Maybe this should be PageConfig.getBaseUrl() instead?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Fixing 404 when loading notebook favicons
Issue Description
This pull request addresses the issue of 404 errors occurring when requesting favicons while executing notebook cells in Notebook 7, particularly when using Binder or a custom base URL. The problem originates from the hard-coded favicon URLs in the
index.tsfile.Proposed Changes
To resolve this issue, I have updated the favicon URLs in the
index.tsfile to be relative to the root of the application rather than hard-coded absolute paths. This change ensures that the correct favicon paths are generated, regardless of the base URL configuration.How This Fixes the Issue
By making the favicon URLs relative, they will adapt to the current application's base URL dynamically. This means that whether the Notebook is hosted on Binder or uses a custom base URL, the favicons will be correctly served without resulting in 404 errors.
Changes Made
index.tsto use relative paths for favicon URLs.Testing
I have tested these changes in the following scenarios:
In each scenario, the favicons were successfully loaded without any 404 errors.
Screenshots
Checklist
index.tswith relative favicon URLs.Related Issue
This pull request fixes issue #[7076].