Skip to content

Commit

Permalink
lower maxDiffPixels
Browse files Browse the repository at this point in the history
  • Loading branch information
@jtpio
jtpio committed Oct 15, 2024
1 parent fe8e08a commit f9528ba
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ui-tests/test/mobile.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ test.describe('Mobile', () => {
await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });

expect(await page.screenshot()).toMatchSnapshot('tree.png', {

Check failure on line 38 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (firefox)

[firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 

  4) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 
    Error: Screenshot comparison failed:

      487 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-diff.png


      36 |     await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
      37 |
    > 38 |     expect(await page.screenshot()).toMatchSnapshot('tree.png', {
         |                                     ^
      39 |       maxDiffPixels: 300,
      40 |     });
      41 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37

Check failure on line 38 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 

  1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 
    Error: Screenshot comparison failed:

      446 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-diff.png


      36 |     await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
      37 |
    > 38 |     expect(await page.screenshot()).toMatchSnapshot('tree.png', {
         |                                     ^
      39 |       maxDiffPixels: 300,
      40 |     });
      41 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37

Check failure on line 38 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 

  1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Screenshot comparison failed:

      446 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-diff.png


      36 |     await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
      37 |
    > 38 |     expect(await page.screenshot()).toMatchSnapshot('tree.png', {
         |                                     ^
      39 |       maxDiffPixels: 300,
      40 |     });
      41 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
maxDiffPixels: 500,
maxDiffPixels: 300,
});
});

Expand Down
4 changes: 2 additions & 2 deletions ui-tests/test/settings.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test.describe('Settings', () => {
await page.reload({ waitUntil: 'networkidle' });
await page.menu.getMenuItem(showHeaderPath);
expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
maxDiffPixels: 500,
maxDiffPixels: 300,
});

await page.waitForSelector('#top-panel', { state: 'hidden' });
Expand All @@ -43,7 +43,7 @@ test.describe('Settings', () => {
await page.reload({ waitUntil: 'networkidle' });
await page.menu.getMenuItem(showHeaderPath);
expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {

Check failure on line 45 in ui-tests/test/settings.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (firefox)

[firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 

  1) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 
    Error: Screenshot comparison failed:

      350 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-firefox-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-visible-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox/top-visible-diff.png


      43 |     await page.reload({ waitUntil: 'networkidle' });
      44 |     await page.menu.getMenuItem(showHeaderPath);
    > 45 |     expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {
         |                                     ^
      46 |       maxDiffPixels: 300,
      47 |     });
      48 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37

Check failure on line 45 in ui-tests/test/settings.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (firefox)

[firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 

  1) [firefox] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: Screenshot comparison failed:

      550 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-firefox-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-visible-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-firefox-retry1/top-visible-diff.png


      43 |     await page.reload({ waitUntil: 'networkidle' });
      44 |     await page.menu.getMenuItem(showHeaderPath);
    > 45 |     expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {
         |                                     ^
      46 |       maxDiffPixels: 300,
      47 |     });
      48 |   });

        at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37
maxDiffPixels: 500,
maxDiffPixels: 300,
});
});
});

0 comments on commit f9528ba

Please sign in to comment.