Skip to content

Commit

Permalink
Wait for the opener button to be visible in notebook toolbar
Browse files Browse the repository at this point in the history
  • Loading branch information
brichet committed May 15, 2024
1 parent 08fe5c5 commit dd178d9
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ui-tests/test/mobile.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Jupyter Development Team.
// Distributed under the terms of the Modified BSD License.

import { IJupyterLabPage, expect, galata } from '@jupyterlab/galata';
import { expect, galata } from '@jupyterlab/galata';

import { test } from './fixtures';

Expand Down Expand Up @@ -68,6 +68,9 @@ test.describe('Mobile', () => {
await hideAddCellButton(notebook);
}

await expect(
notebook.locator('.jp-Toolbar-responsive-opener')
).toBeVisible();

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page

1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: locator('.jp-Toolbar-responsive-opener') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for locator('.jp-Toolbar-responsive-opener') - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" 71 | await expect( 72 | notebook.locator('.jp-Toolbar-responsive-opener') > 73 | ).toBeVisible(); | ^ 74 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); 75 | await notebook.close(); 76 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page

1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: locator('.jp-Toolbar-responsive-opener') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for locator('.jp-Toolbar-responsive-opener') - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" 71 | await expect( 72 | notebook.locator('.jp-Toolbar-responsive-opener') > 73 | ).toBeVisible(); | ^ 74 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); 75 | await notebook.close(); 76 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7

Check failure on line 73 in ui-tests/test/mobile.spec.ts

View workflow job for this annotation

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page

1) [chromium] › test/mobile.spec.ts:41:7 › Mobile › The layout should be more compact on the notebook page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toBeVisible() Locator: locator('.jp-Toolbar-responsive-opener') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for locator('.jp-Toolbar-responsive-opener') - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" - locator resolved to <div data-jp-item-name="toolbar-popup-opener" class="…>…</div> - unexpected value "hidden" 71 | await expect( 72 | notebook.locator('.jp-Toolbar-responsive-opener') > 73 | ).toBeVisible(); | ^ 74 | expect(await notebook.screenshot()).toMatchSnapshot('notebook.png'); 75 | await notebook.close(); 76 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:7
expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
await notebook.close();
});
Expand Down

0 comments on commit dd178d9

Please sign in to comment.