Restore close and shutdown confirmation dialog

jupyter · Jul 25, 2024 · 1b5a56b · 1b5a56b
1 parent 43b8cce
commit 1b5a56b
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/packages/notebook-extension/src/index.ts b/packages/notebook-extension/src/index.ts
@@ -163,9 +163,15 @@ const closeTab: JupyterFrontEndPlugin<void> = {
     commands.addCommand(id, {
       label: trans.__('Close and Shut Down Notebook'),
       execute: async () => {
-        // Shut the kernel down, without confirmation
-        await commands.execute('notebook:shutdown-kernel', { activate: false });
-        window.close();
+        const confirm = window.confirm(
+          trans.__('Are you sure you want to close and shut down the notebook?')
+        );
+        if (confirm) {
+          await commands.execute('notebook:shutdown-kernel', {
+            activate: false,
+          });
+          window.close();
+        }
       },
     });
     menu.fileMenu.closeAndCleaners.add({