Updated integration tests workflow #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
commented
Jul 9, 2024
Comment on lines
-4
to
-8
| workflow_dispatch: | ||
| inputs: | ||
| number: | ||
| description: 'PR number' | ||
| required: true |
There was a problem hiding this comment.
You may want to keep this, but the body of action would probably need some more changes. I recommend merging as-is and restoring the workflow_dispatch later.
andrii-i
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
This updates "Update Playwright Snapshots" workflow in line with JupyterLab https://github.com/jupyterlab/jupyterlab/blob/main/.github/workflows/galata-update.yml. LGTM. Thank you for creating this PR @krassowski.
|
Thanks @andrii-i! I do not have write access on jupyter-server so I have leave it to you or someone else from your team to merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated integration tests workflow