Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub bug, issue, PR templates #534

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Add GitHub bug, issue, PR templates #534

merged 4 commits into from
Jul 8, 2024

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Jul 4, 2024 •
edited
Loading

Adds GitHub bug, issue, PR templates for better user, developer, and contributor experience on GitHub.

@andrii-i andrii-i added the enhancement New feature or request label Jul 4, 2024
srdas
srdas reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@srdas srdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions, feel free to disregard as needed.

.github/pull_request_template.md Outdated Show resolved Hide resolved
@andrii-i andrii-i requested a review from srdas July 8, 2024 16:47
srdas
srdas approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@srdas srdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, approved.

@andrii-i andrii-i changed the title Add bug, issue, PR templates Add GitHub bug, issue, PR templates Jul 8, 2024
JasonWeill
JasonWeill approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of non-blocking changes, otherwise looking good. Thanks!

@andrii-i andrii-i merged commit 43511b6 into jupyter-server:main Jul 8, 2024
6 checks passed
@andrii-i andrii-i deleted the update_templates branch July 8, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdas srdas srdas approved these changes

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-i @srdas @JasonWeill